Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Initial users' status is not fetched #2664

Merged
merged 1 commit into from
Dec 1, 2020
Merged

[FIX] Initial users' status is not fetched #2664

merged 1 commit into from
Dec 1, 2020
+4 −0

Conversation

zaphod534
Copy link
Contributor

Proposed changes

Issue(s)

#2663

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

djorkaeffalexandre
djorkaeffalexandre approved these changes Nov 20, 2020
View reviewed changes
Copy link
Collaborator

@djorkaeffalexandre djorkaeffalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch!
Reproducible steps:

  • Just scroll down the rooms list
  • It's not requesting user presence again

@diegolmello
Copy link
Member

@zaphod534 Can you update your branch?
Also, can you tell me if you have Allow edits by maintainers checked?
We can't add commit (like updating your branch ourselves) with it unchecked.
Thanks.

@zaphod534 zaphod534 force-pushed the fix-initial-users-presence-status branch from 844447a to 5a09f6e Compare December 1, 2020 08:17
@zaphod534
Copy link
Contributor Author

I have updated the PR, now you should be able to merge it.
I tried also to check the Allow edits by maintainers option, but I'm not able to do this due this issue.

We can add you as contributor to our repo in order to be able to check the option next time.

@diegolmello
Copy link
Member

I tried also to check the Allow edits by maintainers option, but I'm not able to do this due this issue.

Awesome. It makes sense now. Thanks!

@diegolmello diegolmello merged commit b61727c into RocketChat:develop Dec 1, 2020
@djorkaeffalexandre djorkaeffalexandre mentioned this pull request Dec 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djorkaeffalexandre djorkaeffalexandre djorkaeffalexandre approved these changes

Assignees
No one assigned
Labels
🛠 fix 👀 needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaphod534 @diegolmello @djorkaeffalexandre